Set boolean config values correctly #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torifat
suggested changes
Jan 13, 2017
|
|
||
| const [key, val = true] = args; | ||
| const key = args[0]; | ||
| const val = BaseRegistry.normalizeConfigOption(args[1] || true); |
There was a problem hiding this comment.
Isn't it better to use yarnConfig without importing BaseRegistry?
There was a problem hiding this comment.
Well, can't use it directly - it's static in BaseRegistry, or do you mean something else?
There was a problem hiding this comment.
But maybe it's better to ensure config is normalized in yarn-registry's saveHomeConfig from the dependency prospective and also to make it more resilient?
Please check the update.
torifat
approved these changes
Jan 14, 2017
|
this PR appears to have introduced a regression (#2856). |
arcanis
pushed a commit
that referenced
this pull request
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn config set [option] [false|true]should set the option value to false/true respectively.
Currently it's set to string value "false"/"true".
Test Plan
yarn config set strict-ssl falsestrict-ssl false